Skip to content

bpo-43997: Add versionadded directives for to match_args, kw_only, and slots in dataclasses.dataclasses documentation#25803

Merged
miss-islington merged 4 commits into
python:masterfrom
shreyanavigyan:bpo-43997
May 2, 2021
Merged

bpo-43997: Add versionadded directives for to match_args, kw_only, and slots in dataclasses.dataclasses documentation#25803
miss-islington merged 4 commits into
python:masterfrom
shreyanavigyan:bpo-43997

Conversation

@shreyanavigyan

@shreyanavigyan shreyanavigyan commented May 2, 2021 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue43997

Automerge-Triggered-By: GH:ericvsmith

@shreyanavigyan shreyanavigyan requested a review from ericvsmith as a code owner May 2, 2021 06:07
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label May 2, 2021
@shreyanavigyan

shreyanavigyan commented May 2, 2021

Copy link
Copy Markdown
Contributor Author

Skip news

ericvsmith
ericvsmith requested changes May 2, 2021
View reviewed changes

@ericvsmith ericvsmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also the kw_only argument to field(). Can you add versionadded there?

@bedevere-bot

bedevere-bot commented May 2, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@shreyanavigyan

shreyanavigyan commented May 2, 2021

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented May 2, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@ericvsmith: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from ericvsmith May 2, 2021 08:09
@miss-islington miss-islington merged commit a5eabc9 into python:master May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericvsmith ericvsmith ericvsmith approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shreyanavigyan @bedevere-bot @ericvsmith @the-knights-who-say-ni @miss-islington